1.8.0 Thyme expression error

[Kilinich]

1.8.0

Algodoo failed to calculate unnecessary code

> [0,1](0) == 0 ? 1 : (1/0)
-- Warning: Failed to evaluate: [0, 1](0) == 0 ? 1 : (1 / 0), Division by zero

> [0,1](0) == 0 ? 1 : (0)
1

[tatt61880]

1.8.0

Algodoo failed to calculate unnecessary code

> [0,1](0) == 0 ? 1 : (1/0)
-- Warning: Failed to evaluate: [0, 1](0) == 0 ? 1 : (1 / 0), Division by zero

> [0,1](0) == 0 ? 1 : (0)
1

The code need a set of {}. (I sometimes forget these {}. )

Good code:
condition ? {true case} : {false case}

Fail code:
condition ? true case : false case

Next code doesn't fail to calculate.

Code: Select all

[0,1](0) == 0 ? {1} : {(1/0)}

[Kilinich]

I know that workaround, but it must work without {} too imho.

> 0 == 0 ? 4/2 : 1/1
2
> 0 == 0 ? 4/2 : 1/0
-- Warning: Caught exception: Division by zero, Source\script\Expressions.cpp:190: class SharedPtr<class script::Object> script::CodeBlock::Evaluate(class SharedPtr<class script::Reflected>,const class script::Settings &)
-- Warning: Failed to evaluate: 0 == 0 ? 4 / 2 : 1 / 0, Division by zero

[ags131]

I noticed that bug too..... (It almost ALWAYS executes false if no {} are used.)

[Sonic]

Bump much?

[Someone Else]

I always use braces around all parts of the IF statement. Partly because it might make things a bit more reliable, partly because it is simply easier to comprehend.

But yeah, this was a pretty useless bump.

[emilk]

use {}. This is just how Thyme work.

[Kilinich]

ok np